gcc: Prevent ICE on no input file #4203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-omkar
force-pushed
the
fix-no-input-segfault-v2
branch
from
9f14789 to
801f9ac
Compare
shreyas-omkar
changed the title
shreyas-omkar
force-pushed
the
fix-no-input-segfault-v2
branch
2 times, most recently
from
5bd12d1 to
ece8296
Compare
* toplev.cc (lang_dependent_init): Prevent ICE on no input file. Signed-off-by: shreyas-omkar <shreyashegdeplus06@gmail.com>
shreyas-omkar
force-pushed
the
fix-no-input-segfault-v2
branch
from
ece8296 to
37210da
Compare
|
Heys @philberty @powerboat9 Please review and let me know any changes required. |
|
Your commit log is not correct and must have a title (the first line), an empty line, and then a description followed by the GNU ChangeLog part. |
dkm
reviewed
Oct 13, 2025
Comment on lines
+1915
to
+1919
| if (name == nullptr) { | ||
| fatal_error(input_location, "no input files"); | ||
| return 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
This probably breaks invocations using stdin instead of a regular file. This probably needs a different fix to use stdin in this case.
There was a problem hiding this comment.
Sure, I will implement the invocation using stdin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3523
Problem Description
Currently, invoking the
crab1compiler front-end without providing an input source file results in an Internal Compiler Error (ICE) due to a segmentation fault.This occurs because a
NULLpointer for the filename is passed tolang_dependent_initand subsequently to lower-level functions likeinit_asm_outputandlrealpath, which do not handle theNULLvalue and lead to a crash.Solution
This patch introduces a check inside the
lang_dependent_initfunction ingcc/toplevel.cc. The check verifies if the input filename isnullptr. If it is, the compiler now reports afatal_error("no input files")and terminates gracefully.This new behavior is more robust, providing a clear error message to the user instead of an unexpected crash, and aligns better with the behavior of other GCC front-ends.
Testing
The fix was verified manually by running the compiler with no arguments and confirming that it now prints the fatal error message instead of segfaulting.
Additionally, a full
make check-rustwas run successfully to ensure that no regressions were introduced by this change.--signoff).make check-rustpasses locally.clang-formaton the changed file.gcc/testsuite/rust/. (Manual test performed to confirm fix).